fix: gate BLS vote-signature failure log behind gobject category

[PastaPastaPasta]

Issue being fixed or feature implemented

In CGovernanceVote::CheckSignature(const CBLSPublicKey&) (src/governance/vote.cpp), a signature verification failure was logged unconditionally via LogPrintf instead of LogPrint(BCLog::GOBJECT, ...), unlike key ID signature verification and the rest of vote validation.
After PR #7527 (orphan governance votes must pass GovernanceVote::IsValid before caching), a peer holding a valid masternode outpoint (public data) plus an invalid BLS signature can reach this path with a vote naming an arbitrary parent hash, producing a debug.log line per message without -debug=gobject set.

Similarly, CGovernanceObject::ProcessVote (src/governance/object.cpp) logged unsupported vote signals and invalid votes via unconditional LogPrintf.

What was done?

Updated the unconditional LogPrintf calls in CGovernanceVote::CheckSignature and CGovernanceObject::ProcessVote to use LogPrint(BCLog::GOBJECT, ...).

• src/governance/vote.cpp: CGovernanceVote::CheckSignature(const CBLSPublicKey&)
• src/governance/object.cpp: CGovernanceObject::ProcessVote (unsupported vote signal and invalid vote paths)

How Has This Been Tested?

• Built locally with dependencies prefix.
• Unit tests (./src/test/test_dash --run_test="*gov*") pass.
• Log and whitespace linters (test/lint/lint-logs.py, test/lint/lint-whitespace.py) pass.

Breaking Changes

None.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

This pull request was created by Codex.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[PastaPastaPasta]

LGTM

[coderabbitai]

Walkthrough

Governance vote validation messages now use category-based LogPrint calls with BCLog::GOBJECT instead of unconditional LogPrintf calls. Vote validation, error classification, and rejection behavior remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes gating BLS vote-signature failure logs behind the gobject category.
Description check	✅ Passed	The description accurately explains the logging changes, affected code paths, testing, and absence of breaking changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

src/governance/object.cpp (1)

411-411: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Verify regression coverage for the logging-category contract.

If existing governance tests do not cover these paths, add a focused test that verifies the messages are emitted only when BCLog::GOBJECT is enabled. Also cover the related change in src/governance/vote.cpp line 204.

As per coding guidelines, governance changes must add small tests that prove the changed invariant.

Also applies to: 462-462

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/governance/object.cpp` at line 411, Add focused governance tests covering
the logging paths in object.cpp and vote.cpp, verifying messages are emitted
only when BCLog::GOBJECT is enabled and suppressed when it is disabled. Reuse
existing logging-test utilities and cover both referenced object.cpp locations
plus the related vote.cpp path.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/governance/object.cpp`:
- Line 411: Add focused governance tests covering the logging paths in
object.cpp and vote.cpp, verifying messages are emitted only when BCLog::GOBJECT
is enabled and suppressed when it is disabled. Reuse existing logging-test
utilities and cover both referenced object.cpp locations plus the related
vote.cpp path.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e90c0f8-3dff-4ae6-a1aa-e0aff43e1b06

📥 Commits

Reviewing files that changed from the base of the PR and between 3d0b7c1 and afe5fda.

📒 Files selected for processing (2)

• src/governance/object.cpp
• src/governance/vote.cpp

[thepastaclaw]

⛔ Blockers found — Opus deferred (commit afe5fda)
Canonical validated blockers: 1