chore: bump grovedb to 33a3ad34 (per-instance query limits) - #4564
Conversation
Pulls in grovedb #844 + #845: per-instance `Query::limit` (wire format, trusted-read engine, V1 prover/verifier accounting) and the merge lifting that turns a limited input's global SizedQuery::limit into its merged branch's per-instance limit — `prove_query_many` now serves limited path queries and the verifier re-derives the identical merged query. Query-side only, gated on GROVE_V4 (merge slot 2); no write repricing, no consensus impact, and every existing query keeps its exact wire bytes (grovedb golden pins). The two `grovedb_query::Query` struct literals in the shielded encrypted-notes surface gain the new `limit: None` field explicitly. This is what lets a chained document query (provable semi-join) be served as ONE merged proof: the limited inner indexOnly page and the derived outer by-ids fetch merge into a single PathQuery whose inner branch carries the lifted per-instance cap. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughChangesGroveDB and shielded note query updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This dependency pin updates bounded query and proof behavior without identified impact to correctness, security, or availability. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (6 skipped: 6 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🕓 Ready for review — 33 ahead in queue (commit cc008f8) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.2-dev #4564 +/- ##
============================================
- Coverage 87.57% 85.17% -2.41%
============================================
Files 2748 2778 +30
Lines 357005 367741 +10736
============================================
+ Hits 312647 313220 +573
- Misses 44358 54521 +10163
🚀 New features to boost your workflow:
|
Issue being fixed or feature implemented
Pin bump to grovedb
33a3ad34(develop head), pulling in exactly two PRs on top of the current pin (0a3b3f9b):Query::limit): wire format (encoding v3, canonical, fail-closed pre-V4), trusted-read engine, fail-closed gates everywhere else.path_query_methods.merge = 2, GROVE_V4): a limited input's globalSizedQuery::limitbecomes its merged branch'sQuery::limit, soprove_query_manynow serves limited path queries and the verifier re-derives the identical merged query.Query-side only: no write repricing, no consensus impact, and every already-expressible query keeps its exact wire bytes (grovedb golden pins cover this). The feature activates under GROVE_V4, which PV14 selects.
What was done?
grovedb*rev in the six workspace Cargo.tomls + lockfile.grovedb_query::Querystruct literals in the shielded encrypted-notes surface gain the newlimit: Nonefield explicitly — the only compile impact in the workspace.Why now
This is the enabler for serving chained document queries (the provable semi-join stack: #4547 → #4549 → #4552 → #4555) as one merged proof: the limited inner indexOnly page and the derived outer by-ids fetch merge into a single
PathQuerywhose inner branch carries the lifted per-instance cap — replacing the two-proof + root-equality envelope. That stack will be rebased onto this chore.How Has This Been Tested?
cargo check --workspaceclean;cargo test -p drive index_only(42/42) as the grovedb-heavy smoke; grovedb's own suite at this rev is 5125 passing per #845.Breaking Changes
None.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Maintenance