fix: identifier deserialization doesn't work for bincode#885
Merged
Conversation
QuantumExplorer
approved these changes
Apr 4, 2023
markin-io
pushed a commit
that referenced
this pull request
Apr 26, 2023
5 tasks
markin-io
pushed a commit
that referenced
this pull request
Apr 26, 2023
5 tasks
QuantumExplorer
added a commit
that referenced
this pull request
Jul 14, 2026
…hip, node id, restore & lifecycle fixes Bumps the pin for rust-dashcore #882 (operator gap-limit extension), #884 (platform node id = Tenderdash SHA256[0..20], fixing our #883) and #885 (dedicated PlatformNodeId newtype). Addresses the review blockers on the masternode feature: - Ownership maps are rebuilt from the managed provider pools: operator scans through the pool's high-water mark (not a hardcoded 20-window) so #882/restored beyond-gap keys match; platform node ownership reads the persisted EdDSA batch with node ids recomputed under #884 (the lifecycle is seedless, so seed-derivation never fired). - Platform-node key batch is threaded restore→FFI→pool as typed EdDSA entries; MasternodeSync never downgrades a true ownership flag on a transient absent signal. - Address-pool restore keeps prederived typed BLS/EdDSA keys instead of clobbering them with the ECDSA-shaped FFI row. - Claim button gated off (withdrawal is still a stub); wallet deletion purges PersistentMasternode; list_masternodes writes empty outputs before fallible lookups. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
6 tasks
shumkov
added a commit
that referenced
this pull request
Jul 14, 2026
…y-invitations Both sides had bumped rust-dashcore past the PlatformNodeId newtype (#885): v4.1-dev's #4120 pinned 38c689d9 (a descendant of this branch's ac8828c9, adding #889 canonical byte order + #891 tx-record positions), so the dependency block resolves to v4.1-dev's newer rev — git's auto-merge had duplicated the whole [workspace.dependencies] table, so it was reconciled by hand back to a single block. peers.rs and core_wallet_types.rs take v4.1-dev's variants of the same PlatformNodeId adaptations both sides had made independently. persistence.rs: #4120 extracted the load-side pool-restore loop into restore_core_address_pools() with funds + provider-key routing, but the extraction was based on v4.1-dev's copy and so dropped this branch's asset-lock funding-account arms (identity registration / top-up / invitation / address top-up) — the voucher-key-reuse restore fix. The merge takes the helper and re-adds those six arms (with the security rationale comment); the FFIPersister durability attestation from the round-5 fix is preserved. Post-merge: workspace check + clippy --all-features + fmt clean; platform-wallet 460 and platform-wallet-ffi 169 tests green (both suites now include the base's new provider-key restore tests). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Identifier deserialization doesn't work for bincode
What was done?
Identifier::from_json_objectHow Has This Been Tested?
With tests
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only