Rust Abci Execution#883
Merged
Merged
Conversation
…drive-abci (#842) Co-authored-by: Igor Markin <igor.markin@dash.org> Co-authored-by: Mikhail Pshenichnikov <pshenmic@gmail.com>
…to feat/abci_validation
…to feat/abci_validation
Co-authored-by: pshenmic <pshenmic@gmail.com> Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
Member
Author
|
We are going to merge this into to v25 broken. Reviews are going to take place from tomorrow but after merge. v0.25 will only become the main branch after CI is passing. |
QuantumExplorer
added a commit
that referenced
this pull request
Jul 14, 2026
…hip, node id, restore & lifecycle fixes Bumps the pin for rust-dashcore #882 (operator gap-limit extension), #884 (platform node id = Tenderdash SHA256[0..20], fixing our #883) and #885 (dedicated PlatformNodeId newtype). Addresses the review blockers on the masternode feature: - Ownership maps are rebuilt from the managed provider pools: operator scans through the pool's high-water mark (not a hardcoded 20-window) so #882/restored beyond-gap keys match; platform node ownership reads the persisted EdDSA batch with node ids recomputed under #884 (the lifecycle is seedless, so seed-derivation never fired). - Platform-node key batch is threaded restore→FFI→pool as typed EdDSA entries; MasternodeSync never downgrades a true ownership flag on a transient absent signal. - Address-pool restore keeps prederived typed BLS/EdDSA keys instead of clobbering them with the ECDSA-shaped FFI row. - Claim button gated off (withdrawal is still a stub); wallet deletion purges PersistentMasternode; list_masternodes writes empty outputs before fallible lookups. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This PR is for Rust Abci execution. And includes a lot of changes:
The advantage is that state transitions are now atomic.
Operator now has a system key for Node id
What was done?
This is a mega PR that brings with it the main Platform executor written in Rust.
How Has This Been Tested?
A lot of strategy tests.
Breaking Changes
We removed JS-Drive and JS-DPP.
Checklist:
For repository code-owners and collaborators only