feat(agg index): initial impl refresh index - #11634
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
Bot
added
the
pr-feature
ariesdevil
force-pushed
the
refresh-index_ariesdevil
branch
3 times, most recently
from
June 7, 2023 18:12
fa351cc to
7023976
Compare
ariesdevil
force-pushed
the
refresh-index_ariesdevil
branch
2 times, most recently
from
June 12, 2023 12:02
d48e7ec to
9a031a8
Compare
ariesdevil
force-pushed
the
refresh-index_ariesdevil
branch
3 times, most recently
from
June 13, 2023 08:27
c19e8ea to
783cbcb
Compare
ariesdevil
marked this pull request as ready for review
June 13, 2023 08:37
ariesdevil
force-pushed
the
refresh-index_ariesdevil
branch
2 times, most recently
from
June 13, 2023 10:26
a5ed823 to
3968e9a
Compare
Member
|
Please add the summary about this PR :) |
Member
|
From the PR codes, it looks like a new feature, is it ready to add logic test for this PR or next? |
Contributor
Author
The logic tests are not suite for refresh index, we need design new test for this feature, this PR will merge first so that the it not stuck the read side by @RinChanNOWWW I'll continue work on refresh index includes: partial refresh by limit, add new field to index meta, add metrics, and so on. |
ariesdevil
force-pushed
the
refresh-index_ariesdevil
branch
from
June 13, 2023 12:03
3968e9a to
f1cd678
Compare
Contributor
Author
|
I have encountered some problems in the development process on the correspondence between blocks and underlying files, and I especially appreciate @sundy-li @RinChanNOWWW @zhang2014 help, although some of the suggestions are not used in the end :) |
Contributor
|
Better to add some unit tests to mock the index writing. |
zhang2014
reviewed
Jun 14, 2023
zhang2014
reviewed
Jun 14, 2023
ariesdevil
force-pushed
the
refresh-index_ariesdevil
branch
4 times, most recently
from
June 18, 2023 15:07
d21d19f to
8642b74
Compare
ariesdevil
force-pushed
the
refresh-index_ariesdevil
branch
3 times, most recently
from
June 19, 2023 13:46
655ab4a to
d64cfc6
Compare
ariesdevil
force-pushed
the
refresh-index_ariesdevil
branch
from
June 20, 2023 10:36
d64cfc6 to
cec5a43
Compare
sundy-li
reviewed
Jun 20, 2023
ariesdevil
force-pushed
the
refresh-index_ariesdevil
branch
from
June 20, 2023 14:58
cec5a43 to
92f0be4
Compare
ariesdevil
force-pushed
the
refresh-index_ariesdevil
branch
from
June 20, 2023 15:23
92f0be4 to
fff83e7
Compare
sundy-li
approved these changes
Jun 21, 2023
RinChanNOWWW
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Initial impl refresh index.
Closes #issue