Skip to content

chore(parser): rearrange file structure of common_ast - #5000

Merged
bohutang merged 6 commits into
databendlabs:mainfrom
andylokandy:refactor
Apr 22, 2022
Merged

chore(parser): rearrange file structure of common_ast#5000
bohutang merged 6 commits into
databendlabs:mainfrom
andylokandy:refactor

Conversation

@andylokandy

@andylokandy andylokandy commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • remove AstVistor
  • move files around for a cleaner structure

Changelog

  • Improvement

Related Issues

@vercel

vercel Bot commented Apr 22, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Apr 22, 2022 at 5:50AM (UTC)

@mergify

mergify Bot commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@andylokandy

Copy link
Copy Markdown
Contributor Author

@mergify update

@mergify

mergify Bot commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

update

✅ Branch has been successfully updated

@andylokandy
andylokandy requested a review from leiysky April 22, 2022 04:38

@leiysky leiysky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xudong963

Copy link
Copy Markdown
Contributor

Related to #4945 ?

@bohutang
bohutang merged commit 1c3fcf2 into databendlabs:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants