Skip to content

feat(planner): Fold simple count aggregation#7414

Merged
mergify[bot] merged 2 commits into
databendlabs:mainfrom
leiysky:simple-count
Sep 1, 2022
Merged

feat(planner): Fold simple count aggregation#7414
mergify[bot] merged 2 commits into
databendlabs:mainfrom
leiysky:simple-count

Conversation

@leiysky

@leiysky leiysky commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Fold simple COUNT() aggregation if the precise statistics information is available.

This will accelerate the queries like:

select count(*) from t;

Close #7267

@vercel

vercel Bot commented Aug 31, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 4:49AM (UTC)

@mergify mergify Bot added the pr-feature this PR introduces a new feature to the codebase label Aug 31, 2022
@leiysky
leiysky requested a review from bohutang August 31, 2022 07:59
Comment thread src/query/service/src/sql/executor/format.rs
@bohutang
bohutang requested a review from sundy-li August 31, 2022 10:43
@leiysky

leiysky commented Sep 1, 2022

Copy link
Copy Markdown
Contributor Author

@mergify update

@mergify

mergify Bot commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

update

✅ Branch has been successfully updated

@mergify
mergify Bot merged commit a2d0c3f into databendlabs:main Sep 1, 2022
@leiysky
leiysky deleted the simple-count branch September 1, 2022 05:21
RelOperator::DummyTableScan(_) => {
let catalogs = self.ctx.get_catalog_manager()?;
let table = catalogs
.get_catalog(CATALOG_DEFAULT)?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leiysky , using 'CATALOG_DEFAULT', does it infect hive query?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

optimizer_statistics_exact is missing in new planner

6 participants