Migrate to Starlette 1.0#271
Merged
khoroshevskyi merged 7 commits intodevfrom Apr 22, 2026
Merged
Conversation
Starlette 1.0.0 is now the installed version (pulled in by an unrelated
CI rebuild on 2026-04-16). This commit migrates the codebase to the
Starlette 1.0 idioms that replace the removed/deprecated pre-1.0 APIs.
- TemplateResponse: use (request, name, context) signature; drop
request from the context dict (was causing TypeError: unhashable
type: 'dict' on GET /v1).
- Lifespan handler replaces module-import-time global state
(BackgroundScheduler, bbagent, usage_data, ref_validator) with
app.state + FastAPI Depends() injection in dependencies.py.
- Pydantic v2 / FastAPI 0.100+ kwargs: regex= -> pattern=,
example= -> examples=[...] in data_models.py.
- starlette.responses imports -> fastapi.responses in helpers.py.
- Duplicate endpoint function names renamed (get_bedbase_db_stats x3,
get_bedset_metadata x3, embed_bed_file x2, get_tokens x2) to
unblock request.url_for(name=...) lookups.
- HTTPException(status_code=...) calls in bed_api.py get explicit
detail=; fix return HTTPException(...) -> raise.
- uvicorn.run("bedhost.main:app", ...) import-string form.
- dependencies.py no longer imports from main; fetch_detailed_stats
takes bbagent as argument.
No version pins added. No backwards-compatibility shims.
When BEDHOST_INIT_ML=false, app.state.ref_validator is None. Previously analyze_reference_genome would unconditionally call ref_validator.determine_compatibility, raising AttributeError and returning 500. Return a clean 503 instead.
3 tasks
Deploying bedhost-ui with
|
| Latest commit: |
9d2a7d8
|
| Status: | ⚡️ Build in progress... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TemplateResponsenew signature, lifespan handler,app.state+Depends()for bbagent/usage_data/ref_validator, Pydantic v2 kwargs,fastapi.responses, duplicate endpoint name fixes,HTTPExceptiondetail cleanup, uvicorn import-string form).analyze_reference_genomeagainstNoneref_validator whenBEDHOST_INIT_ML=false.sentence_transformers>=5.0(bbconf importsSparseEncoder).Fixes the HTTP 500 on
/v1caused by the deprecated pre-1.0TemplateResponse(name, context_with_request)signature that Starlette 1.0 finalized as removed.Test plan
/v1,/v1/openapi.json,/v1/docs/changelog,/v1/stats,/v1/bed/listall return 200compliance-testsbranch) pass against redeployed API