Fix missing_role golden: backend error has trailing (not "")!#5910
Merged
Conversation
The postgres_databases/live_errors/missing_role acceptance test fails on
aws-ucws because the real Lakebase backend returns
Field 'database.spec.role' is required, expected non-default value (not "")!
but the testserver fake and the golden omit the trailing (not "")! suffix.
Every other postgres field error in libs/testserver/postgres.go already
carries that suffix (project_id, branch_id, endpoint_id, database_id,
catalog_id, synced_table_id) - the role error was the odd one out.
Align the fake's error string with the real backend and regenerate the
golden. The contains.py assertion stays on the stable prefix so it does not
have to chase future suffix changes.
Verified on aws-ucws:
deco env run -i -n aws-prod-ucws -- go test ./acceptance \
-run '.../postgres_databases/live_errors/missing_role'
Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
Integration test reportCommit: a6528ee
8 interesting tests: 4 SKIP, 3 KNOWN, 1 RECOVERED
Top 10 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Jul 13, 2026
janniklasrose
left a comment
janniklasrose
left a comment
Contributor
There was a problem hiding this comment.
oops, somehow my Claude missed this in the last PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
postgres_databases/live_errors/missing_roleacceptance test, which fails on aws-ucws because the real Lakebase backend returnsField 'database.spec.role' is required, expected non-default value (not "")!but the testserver fake and the golden omit the trailing(not "")!suffix.Every other postgres field error in
libs/testserver/postgres.goalready carries that suffix (project_id, branch_id, endpoint_id, database_id, catalog_id, synced_table_id) — the role error was the odd one out. This aligns the fake's error string with the real backend and regenerates the golden. Thecontains.pyassertion stays on the stable prefix so it doesn't have to chase future suffix changes.Co-authored-by: Isaac