Skip to content

Fix missing_role golden: backend error has trailing (not "")! #5910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pietern merged 1 commit into from
Jul 13, 2026
+3 −3
Merged

Fix missing_role golden: backend error has trailing (not "")! #5910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions acceptance/bundle/resources/postgres_databases/live_errors/missing_role/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/missing-role-[UNIQUE_NAME]/default/files...
Deploying resources...
Error: cannot create resources.postgres_databases.my_database: Field 'database.spec.role' is required, expected non-default value (400 INVALID_PARAMETER_VALUE)
Error: cannot create resources.postgres_databases.my_database: Field 'database.spec.role' is required, expected non-default value (not "")! (400 INVALID_PARAMETER_VALUE)

Endpoint: POST [DATABRICKS_URL]/api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main/databases?database_id=my-database
HTTP Status: 400 Bad Request
API error_code: INVALID_PARAMETER_VALUE
API message: Field 'database.spec.role' is required, expected non-default value
API message: Field 'database.spec.role' is required, expected non-default value (not "")!

Updating deployment state...

Expand Down
2 changes: 1 addition & 1 deletion libs/testserver/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,7 @@ func (s *FakeWorkspace) PostgresDatabaseCreate(req Request, parent, databaseID s
// one with this exact error (verified on aws-ucws 2026-07-13). The fake does
// not synthesize a default, matching that behavior.
if database.Spec == nil || database.Spec.Role == "" {
return postgresErrorResponse(400, "INVALID_PARAMETER_VALUE", "Field 'database.spec.role' is required, expected non-default value")
return postgresErrorResponse(400, "INVALID_PARAMETER_VALUE", `Field 'database.spec.role' is required, expected non-default value (not "")!`)
}

name := fmt.Sprintf("%s/databases/%s", parent, databaseID)
Expand Down
Loading