Show skill scopes per agent - #485
Open
artjen wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to status rendering, reuses the canonical scope-resolution helper, and is covered by a focused CLI test.
Pull request overview
Updates ucode status to accurately reflect agent-scoped Skills MCP configuration by displaying each client’s effective skill scope when clients differ, while keeping the prior compact output when all configured clients share the same scope.
Changes:
- Compute per-client effective skill locations using the shared
skill_locations_for_client(...)helper. - Render either a single shared “Skill MCP Locations” row (when identical) or per-client rows (when divergent).
- Add a CLI regression test covering divergent per-agent scopes.
File summaries
| File | Description |
|---|---|
| src/ucode/cli.py | Enhances status() Skills section to compute and render per-client effective skill scopes when they differ. |
| tests/test_cli.py | Adds coverage asserting ucode status renders separate skill-location lines for clients when scopes diverge. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
artjen
force-pushed
the
skill-agent-status
branch
from
September 3, 2026 20:32
fe70b39 to
5774835
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The change is localized to status() rendering, leverages the existing scope helper, and is covered by an added CLI test for divergent scopes.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Once agents can have different skill scopes, the old status output is misleading because it shows only the shared list. Developers need to see the effective scope each agent will actually receive.
What changed
This PR makes
ucode statusdisplay skill MCP locations per agent when those effective scopes differ.How it works
Builds on agent-scoped configuration in #484.
Testing
uv run pytest tests/test_skills_download.py tests/test_mcp.py tests/test_cli.py -q— 502 passeduv run ruff check .uv run ty check src/Manual staging validation
Validated the stack through this PR against
https://eng-ml-inference.staging.cloud.databricks.comwithartjen.default.ucode-pr3-cli-smoke.artjen.defaultto Codex only, then to Claude Code only.ucode statusand each client's MCP URL showed only the intended agent-specific schema.skill_artjen.default.ucode-pr3-cli-smokeand returnedUCODE_PR3_SCOPE_OK.Stack created with GitHub Stacks CLI • Give Feedback 💬