Remove auto-flattening for unpack_arcs. #244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the auto-flattening of unpack_arcs leads to the following scenario:
Two properties are requested for a given entity but data only exists for one of the properties. The REST api will not contain the property with no data in the response, therefore we cannot tell from only the response the difference between one property requested and one property out of multiple properties requested contains data.
An example:
In the response from get_properties(), we can't tell if it's for encodesGene or variantID.
A long term fix for this would be to store the original requested properties in the NodeResponse object and only do this "autoflattening" when there was one requested property. However, another consideration is that many return types for a single method can cause a lot confusion.