Skip to content

Conversation

@chejennifer
Copy link
Contributor

Fixes this error in fetch_entity_names: https://screenshot.googleplex.com/Bm9BzSUnNYB87N9

There was a recent change that removes auto-flattening when unpacking arcs (#244), but fetch_entity_names was still assuming that values would be flattened.

Also updated the tests to use mock responses that are formatted the way the response would actually come back as.

Copy link
Contributor

@clincoln8 clincoln8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!!

To fix lint errors, run

pip install hatch
hatch env create
hatch run lint:format

(https://github.com/datacommonsorg/api-python/blob/master/docs/development.md#code-style-and-linting)
this is different than the styling used in website repo.

Copy link
Contributor

@jm-rivera jm-rivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this and improving the tests @chejennifer!

@chejennifer chejennifer merged commit 60f4c7d into datacommonsorg:master Apr 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants