Skip to content

[Vis Tools] Delete old, old Timeline Tool#6168

Merged
juliawu merged 3 commits intodatacommonsorg:masterfrom
juliawu:vis-tool-cleanup-timeline
Apr 2, 2026
Merged

[Vis Tools] Delete old, old Timeline Tool#6168
juliawu merged 3 commits intodatacommonsorg:masterfrom
juliawu:vis-tool-cleanup-timeline

Conversation

@juliawu
Copy link
Copy Markdown
Contributor

@juliawu juliawu commented Apr 2, 2026

This PR removes the codepaths that supported the old, un-revamped /tools/timeline UI.

Summary

Now that the "standardized_vis_tool" experience is the default experience, this PR removes the old /tools/timeline experience so that we can eventually delete the flag. In order to keep changes concise, I've only removed the old /tools/timeline in this PR. Removing /tools/visualization will come in a separate PR.

Related PRs:
/tools/map is being removed in #6165
/tools/scatter is being removed in #6167

Testing Strategy

Locally, I set the "standardized_vis_tool" flag to False, and verified that:

  • navigating to localhost:8080/tools/timeline still renders the new, standardized experience.
  • webdriver, client, and python tests still pass

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completes the transition to the standardized visualization tool for the timeline page by removing all legacy code paths and UI components. By making the standardized experience the default and only implementation, this change simplifies the codebase and prepares for the eventual removal of associated feature flags.

Highlights

  • Removal of Legacy Timeline UI: Removed all code paths, templates, and configurations associated with the old, un-revamped /tools/timeline UI, standardizing on the new visualization tool experience.
  • Test Suite Cleanup: Updated webdriver tests to remove legacy test mixins and feature flag-based test cases, ensuring the test suite now only validates the standardized timeline experience.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the feature flag for the standardized timeline tool, making it the permanent UI. The changes include simplifying the backend route in html.py, updating the Jinja2 template, deleting the legacy info.tsx component, and refactoring the React Page component to remove conditional logic. Additionally, the WebDriver tests have been consolidated to reflect the removal of the old UI. I have no feedback to provide as there were no review comments to evaluate.

@juliawu juliawu requested a review from nick-nlb April 2, 2026 20:16
@juliawu juliawu marked this pull request as ready for review April 2, 2026 20:16
Copy link
Copy Markdown
Contributor

@nick-nlb nick-nlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliawu juliawu enabled auto-merge (squash) April 2, 2026 21:30
@juliawu juliawu merged commit bc09e0b into datacommonsorg:master Apr 2, 2026
13 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Apr 13, 2026
# Highlights
- [Vis Tools] Delete old, old Map Tool by @juliawu in #6165, #6168 and
#6170
- Update webdriver recordings by @nick-nlb in #6169
- [v0/v1 migration] Replace /v1/variable/search by @nick-nlb in #6140
- [Ranking Page][Ranking Tile] Add pagination to the ranking tile by
@juliawu in #6147
- Upgrade google-adk from 1.18.0 to 1.28.1. by @nick-nlb in #6172
- Bump setuptools from 66.1.1 to 78.1.1 in /server by
https://github.com/dependabot[bot] in #6173
-

# Resources - REMOVE BEFORE MERGING
- Diff links to help with writing highlights:
- Mixer:
datacommonsorg/mixer@f8a47a4...00b8206
- Import:
datacommonsorg/import@1e14cdc...fced75e
- Website changes are listed on this page.
- If you're unsure what affects custom DC, please message the team.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants