[Vis Tools] Delete old, old Timeline Tool#6168
[Vis Tools] Delete old, old Timeline Tool#6168juliawu merged 3 commits intodatacommonsorg:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completes the transition to the standardized visualization tool for the timeline page by removing all legacy code paths and UI components. By making the standardized experience the default and only implementation, this change simplifies the codebase and prepares for the eventual removal of associated feature flags. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the feature flag for the standardized timeline tool, making it the permanent UI. The changes include simplifying the backend route in html.py, updating the Jinja2 template, deleting the legacy info.tsx component, and refactoring the React Page component to remove conditional logic. Additionally, the WebDriver tests have been consolidated to reflect the removal of the old UI. I have no feedback to provide as there were no review comments to evaluate.
# Highlights - [Vis Tools] Delete old, old Map Tool by @juliawu in #6165, #6168 and #6170 - Update webdriver recordings by @nick-nlb in #6169 - [v0/v1 migration] Replace /v1/variable/search by @nick-nlb in #6140 - [Ranking Page][Ranking Tile] Add pagination to the ranking tile by @juliawu in #6147 - Upgrade google-adk from 1.18.0 to 1.28.1. by @nick-nlb in #6172 - Bump setuptools from 66.1.1 to 78.1.1 in /server by https://github.com/dependabot[bot] in #6173 - # Resources - REMOVE BEFORE MERGING - Diff links to help with writing highlights: - Mixer: datacommonsorg/mixer@f8a47a4...00b8206 - Import: datacommonsorg/import@1e14cdc...fced75e - Website changes are listed on this page. - If you're unsure what affects custom DC, please message the team.
This PR removes the codepaths that supported the old, un-revamped /tools/timeline UI.
Summary
Now that the "standardized_vis_tool" experience is the default experience, this PR removes the old /tools/timeline experience so that we can eventually delete the flag. In order to keep changes concise, I've only removed the old /tools/timeline in this PR. Removing /tools/visualization will come in a separate PR.
Related PRs:
/tools/map is being removed in #6165
/tools/scatter is being removed in #6167
Testing Strategy
Locally, I set the "standardized_vis_tool" flag to False, and verified that: