Update webdriver recordings#6169
Conversation
… metadata/facet endpoint and regenerate the recordings for the webdriver tests.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the WebDriver test suite to align with recent changes in the application's UI and data sources. Additionally, it introduces necessary infrastructure for the metadata/facet endpoint, including fallback responses and request hashing, to ensure robust testing and functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for the /api/metadata/facets endpoint in the recorder by implementing a fallback response and defining hashing parameters. Additionally, it updates several WebDriver tests to reflect changes in place names (shortening "United States of America" to "United States"), ranking results, and data source URLs. I have no feedback to provide.
…m, and update the webdriver test recordings to include the custom run.
# Highlights - [Vis Tools] Delete old, old Map Tool by @juliawu in #6165, #6168 and #6170 - Update webdriver recordings by @nick-nlb in #6169 - [v0/v1 migration] Replace /v1/variable/search by @nick-nlb in #6140 - [Ranking Page][Ranking Tile] Add pagination to the ranking tile by @juliawu in #6147 - Upgrade google-adk from 1.18.0 to 1.28.1. by @nick-nlb in #6172 - Bump setuptools from 66.1.1 to 78.1.1 in /server by https://github.com/dependabot[bot] in #6173 - # Resources - REMOVE BEFORE MERGING - Diff links to help with writing highlights: - Mixer: datacommonsorg/mixer@f8a47a4...00b8206 - Import: datacommonsorg/import@1e14cdc...fced75e - Website changes are listed on this page. - If you're unsure what affects custom DC, please message the team.
Description
The webdriver tests recordings were out-of-date and notably did not contain recordings for the metadata/facet endpoints (which are heavy on mixer).
This PR
Notes
The custom DC tests in some cases currently expect slightly different data (or forms of the same data) than the primary tests. Some tests were updated to make them more flexible.