Skip to content

Update webdriver recordings#6169

Merged
nick-nlb merged 4 commits intodatacommonsorg:masterfrom
nick-nlb:testing_update_recordings
Apr 2, 2026
Merged

Update webdriver recordings#6169
nick-nlb merged 4 commits intodatacommonsorg:masterfrom
nick-nlb:testing_update_recordings

Conversation

@nick-nlb
Copy link
Copy Markdown
Contributor

@nick-nlb nick-nlb commented Apr 2, 2026

Description

The webdriver tests recordings were out-of-date and notably did not contain recordings for the metadata/facet endpoints (which are heavy on mixer).

This PR

  • Updates the tests for data drift
  • Adds hashing and fallback entries for the metadata/facet endpoint
  • Regenerates the recordings.

Notes

The custom DC tests in some cases currently expect slightly different data (or forms of the same data) than the primary tests. Some tests were updated to make them more flexible.

… metadata/facet endpoint and regenerate the recordings for the webdriver tests.
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the WebDriver test suite to align with recent changes in the application's UI and data sources. Additionally, it introduces necessary infrastructure for the metadata/facet endpoint, including fallback responses and request hashing, to ensure robust testing and functionality.

Highlights

  • WebDriver Test Updates: Updated multiple WebDriver tests to reflect changes in UI text and data sources, ensuring test stability and accuracy.
  • Metadata Facet Support: Added hashing and fallback response handling for the metadata/facet endpoint to support improved data retrieval.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the /api/metadata/facets endpoint in the recorder by implementing a fallback response and defining hashing parameters. Additionally, it updates several WebDriver tests to reflect changes in place names (shortening "United States of America" to "United States"), ranking results, and data source URLs. I have no feedback to provide.

nick-nlb added 2 commits April 2, 2026 14:09
…m, and update the webdriver test recordings to include the custom run.
@nick-nlb nick-nlb marked this pull request as ready for review April 2, 2026 21:32
@nick-nlb nick-nlb requested a review from juliawu April 2, 2026 21:40
Copy link
Copy Markdown
Contributor

@juliawu juliawu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nick-nlb nick-nlb enabled auto-merge (squash) April 2, 2026 22:46
@nick-nlb nick-nlb merged commit 534bbae into datacommonsorg:master Apr 2, 2026
13 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Apr 13, 2026
# Highlights
- [Vis Tools] Delete old, old Map Tool by @juliawu in #6165, #6168 and
#6170
- Update webdriver recordings by @nick-nlb in #6169
- [v0/v1 migration] Replace /v1/variable/search by @nick-nlb in #6140
- [Ranking Page][Ranking Tile] Add pagination to the ranking tile by
@juliawu in #6147
- Upgrade google-adk from 1.18.0 to 1.28.1. by @nick-nlb in #6172
- Bump setuptools from 66.1.1 to 78.1.1 in /server by
https://github.com/dependabot[bot] in #6173
-

# Resources - REMOVE BEFORE MERGING
- Diff links to help with writing highlights:
- Mixer:
datacommonsorg/mixer@f8a47a4...00b8206
- Import:
datacommonsorg/import@1e14cdc...fced75e
- Website changes are listed on this page.
- If you're unsure what affects custom DC, please message the team.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants