Skip to content

Upgrade google-adk from 1.18.0 to 1.28.1.#6172

Merged
nick-nlb merged 3 commits intodatacommonsorg:masterfrom
nick-nlb:package-upgrade-google-adk
Apr 4, 2026
Merged

Upgrade google-adk from 1.18.0 to 1.28.1.#6172
nick-nlb merged 3 commits intodatacommonsorg:masterfrom
nick-nlb:package-upgrade-google-adk

Conversation

@nick-nlb
Copy link
Copy Markdown
Contributor

@nick-nlb nick-nlb commented Apr 3, 2026

Description

The pinned version of google-adk had a security vulnerability. This PR upgrades that library, along with other libraries that needed to be upgrade as part of the dependency cascade.

Notes

This resulted in a number of dependency upgrades (visible in the updated pyproject.toml file. I upgraded the minimal number of libraries possible to allow us to update google-adk.

One of the updates setuptools being dropped as the dependency tree. This is explicitly restored at a version that allows us to run our test suites.

Note that this resulted in a number of dependency upgrades, including one which resulted in setuptools being dropped as the dependency tree. We also explicitly restore it at a version that allows us to run our test suites.
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a security vulnerability by upgrading the google-adk library. To support this change, a series of cascading dependency updates were performed to ensure system compatibility and stability. Additionally, specific constraints were applied to the test environment to maintain consistent test execution.

Highlights

  • Security Patch: Upgraded google-adk from 1.18.0 to 1.28.1 to address a security vulnerability.
  • Dependency Cascade: Updated several related libraries, including fastapi, google-auth, google-cloud-aiplatform, google-genai, pydantic, and typing-extensions, to maintain compatibility.
  • Environment Configuration: Explicitly added setuptools < 67.0.0 to the test dependencies to ensure test suite stability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several core dependencies in server/pyproject.toml, including fastapi, google-adk, google-auth, google-cloud-aiplatform, google-genai, pydantic, and typing-extensions, and adds a version constraint for setuptools in the test suite. The reviewer recommends updating server/requirements.txt to match these changes and adding documentation to explain the setuptools version pin.

Comment thread server/pyproject.toml
Comment thread server/pyproject.toml
… to explain the restrictive pinning of setuptools.
@nick-nlb nick-nlb marked this pull request as ready for review April 3, 2026 22:03
@nick-nlb nick-nlb requested a review from dwnoble April 3, 2026 22:03
@nick-nlb nick-nlb merged commit 4165921 into datacommonsorg:master Apr 4, 2026
13 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Apr 13, 2026
# Highlights
- [Vis Tools] Delete old, old Map Tool by @juliawu in #6165, #6168 and
#6170
- Update webdriver recordings by @nick-nlb in #6169
- [v0/v1 migration] Replace /v1/variable/search by @nick-nlb in #6140
- [Ranking Page][Ranking Tile] Add pagination to the ranking tile by
@juliawu in #6147
- Upgrade google-adk from 1.18.0 to 1.28.1. by @nick-nlb in #6172
- Bump setuptools from 66.1.1 to 78.1.1 in /server by
https://github.com/dependabot[bot] in #6173
-

# Resources - REMOVE BEFORE MERGING
- Diff links to help with writing highlights:
- Mixer:
datacommonsorg/mixer@f8a47a4...00b8206
- Import:
datacommonsorg/import@1e14cdc...fced75e
- Website changes are listed on this page.
- If you're unsure what affects custom DC, please message the team.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants