Fetch1 checks object length, attribute ordering bug removed #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datajoint/fetch.py
Outdated
Member
There was a problem hiding this comment.
len() is a separate query and can be an expensive operator. Sometimes len() takes as long as the fetch query. It will be more efficient to fetch and to check that the result only has one element.
Member
There was a problem hiding this comment.
Rather than assert, use raise to provide a more manageable error object.
Contributor
|
Changes looks good. |
eywalker
added a commit
that referenced
this pull request
Oct 16, 2015
Fetch1 checks object length, attribute ordering bug removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.