Skip to content

Conversation

@ixcat
Copy link

@ixcat ixcat commented Jun 11, 2018

Fix for #470.

Only tested against current unit tests on unix, which obviously is not a very good test in terms of completeness or correctness. Will hope to do a proper run on windows and also verify the jobs unit test covers the case (probably does, but not 100%), unless someone else feels more confident about impact.

Also, os.getpid() does work on windows; this was verified even if actual change was not otherwise.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 89.294% when pulling 602a152 on ixcat:windows_jobs into fe5f749 on datajoint:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 11, 2018

Coverage Status

Coverage increased (+0.005%) to 89.294% when pulling 602a152 on ixcat:windows_jobs into fe5f749 on datajoint:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants