Skip to content

Conversation

@CBroz1
Copy link
Contributor

@CBroz1 CBroz1 commented Nov 29, 2021

Expanding element-lab for nwb export features, see corresponding PR for workflow-animal/session

  • adding optional foreign keys to support components of nwb export
  • added lab/project/protocol to dict functions for populating NWB for users with element-lab but not element-session

CBroz1 and others added 2 commits November 30, 2021 10:54
Co-authored-by: Thinh Nguyen <thinhnguyen0405@gmail.com>
Co-authored-by: Thinh Nguyen <thinhnguyen0405@gmail.com>
@CBroz1
Copy link
Contributor Author

CBroz1 commented Dec 17, 2021

Ready for review pending resolution of @ttngu207 's comment here

Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
CBroz1 and others added 4 commits December 23, 2021 16:25
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Good catch @kabilar! This was a holdover from my first pass. Now, `element-lab` only has functions for making dicts that feed into a users session-level nwb
@CBroz1 CBroz1 marked this pull request as ready for review January 13, 2022 18:40
@kabilar
Copy link
Collaborator

kabilar commented Jan 28, 2022

Also, pending https://github.com/CBroz1/element-lab/pull/1.

@kabilar kabilar self-assigned this Jan 28, 2022
Empty strings do not populate the NWBFile
CBroz1 and others added 2 commits January 28, 2022 12:51
@kabilar kabilar changed the title nwb export functionality Create dictionaries for NWB export Jan 28, 2022
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CBroz1 and all! Great work.

@kabilar kabilar merged commit c4bc906 into datajoint:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants