Skip to content

Conversation

@kushalbakshi
Copy link
Collaborator

@kushalbakshi kushalbakshi commented Apr 13, 2023

This PR sets up a workflow for element-zstack with the goal of allowing a user to utilize the DataJoint pipeline for processing volumetric data and automatically uploading the results to BossDB.

The following list of items has been completed on this PR:

  • Test the full pipeline in a clean working environment
  • Add CICD
  • Black formatting
  • Set version and CHANGELOG
  • Perform pytest

pytest results:

image

@kushalbakshi kushalbakshi requested a review from kabilar April 13, 2023 19:06
@kushalbakshi kushalbakshi marked this pull request as ready for review April 27, 2023 16:36
@kushalbakshi kushalbakshi requested a review from ttngu207 April 27, 2023 16:36
@kabilar
Copy link
Collaborator

kabilar commented Apr 27, 2023

Has the example data been approved to be made public and subsequently placed in our public S3 bucket?

@kabilar
Copy link
Collaborator

kabilar commented Apr 27, 2023

I could be mistaken, but the only GitHub Actions files we need are in the .github/workflows directory. All others files in the .github directory (except the ISSUE_TEMPLATE) can be deleted.

Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
kushalbakshi and others added 2 commits April 27, 2023 13:11
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
kushalbakshi and others added 2 commits April 27, 2023 13:12
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@kushalbakshi
Copy link
Collaborator Author

Has the example data been approved to be made public and subsequently placed in our public S3 bucket?

I'm following up on this internally now.

I could be mistaken, but the only GitHub Actions files we need are in the .github/workflows directory. All others files in the .github directory (except the ISSUE_TEMPLATE) can be deleted.

This will be updated in the next commit.

kushalbakshi and others added 3 commits May 16, 2023 17:13
Co-authored-by: Kabilar Gunalan <kabilar@datajoint.com>
@kushalbakshi kushalbakshi requested a review from kabilar May 19, 2023 20:03
model_type="nuclei",
channels=[[0, 0]],
z_axis=0,
skip_duplicates=True,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
skip_duplicates=True,

to ensure you have `resource-manager` permissions for your account.
2. Follow the instructions below to set up the
[intern](https://github.com/jhuapl-boss/intern) REST API locally.
+ Create a new folder `.intern` in your root directory.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ Create a new folder `.intern` in your root directory.
+ Create a new folder `.intern` in your user directory.

model_type="nuclei",
channels=[[0, 0]],
z_axis=0,
skip_duplicates=True,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
skip_duplicates=True,

segmentation_method="cellpose",
paramset_idx=2,
params=dict(
diameter=None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be 8 or None?

Suggested change
diameter=None,
diameter=None,


@pytest.fixture(scope="session")
def volume_segmentation_task(pipeline):
volume = pipeline["volume"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
volume = pipeline["volume"]
volume = pipeline["volume"]
key = (volume.Volume & "subject='subject1'").fetch1("KEY")



@pytest.fixture(scope="session")
def volume_segmentation_task(pipeline):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def volume_segmentation_task(pipeline):
def volume_segmentation_param_set(pipeline):

Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kushalbakshi! Great work. Please add my few remaining suggestions in a subsequent pull request.

@kabilar kabilar merged commit ba0f07d into datajoint:main May 19, 2023
@kabilar
Copy link
Collaborator

kabilar commented Aug 22, 2023

Hi @kushalbakshi, when you have a chance, please add these remaining suggestions in a subsequent pull request. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants