Skip to content

Some test improvements and fixes#10356

Merged
potatoqualitee merged 10 commits intodevelopmentfrom
test_fixes
Apr 21, 2026
Merged

Some test improvements and fixes#10356
potatoqualitee merged 10 commits intodevelopmentfrom
test_fixes

Conversation

@andreasjordan
Copy link
Copy Markdown
Collaborator

@andreasjordan andreasjordan commented Apr 20, 2026 •
edited
Loading

  • Not using -Confirm:$false as this is default (where possible).
  • Suppressing some warnings that are not relevant.
  • Enabling remote DAC to help test for New-DbaFirewallRule.
  • Fix test for Get-DbaExternalProcess and Stop-DbaExternalProcess so that the temp file can be removed

@andreasjordan andreasjordan marked this pull request as draft April 20, 2026 11:20
@andreasjordan andreasjordan marked this pull request as ready for review April 21, 2026 08:20
@potatoqualitee
Copy link
Copy Markdown
Member

potatoqualitee commented Apr 21, 2026

hayle yeah thank you 🔥

@potatoqualitee potatoqualitee merged commit 04d24ca into development Apr 21, 2026
14 checks passed
@potatoqualitee potatoqualitee deleted the test_fixes branch April 21, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andreasjordan @potatoqualitee