DBCC Console Commands and Tests#4698
DBCC Console Commands and Tests#4698potatoqualitee merged 9 commits intodataplat:developmentfrom sqllensman:DBCC_SRV
Conversation
|
Ohh this is beautiful 😍!! Thank you! Will do a quick review. |
potatoqualitee
left a comment
potatoqualitee
left a comment
There was a problem hiding this comment.
Incredibly beautiful and better than I could have imagined doing myself, thank you so much!
functions/Get-DbaDbccHelp.ps1
Outdated
| .PARAMETER SqlCredential | ||
| Login to the target instance using alternative credentials. Windows and SQL Authentication supported. Accepts credential objects (Get-Credential) | ||
|
|
||
| .PARAMETER DbccStatement |
There was a problem hiding this comment.
I think Dbcc will be implied - can you change this to just Statement
There was a problem hiding this comment.
Ok. Will update command and tests.
| begin { | ||
| $stringBuilder = New-Object System.Text.StringBuilder | ||
| $null = $stringBuilder.Append("DBCC USEROPTIONS WITH NO_INFOMSGS") | ||
| } |
There was a problem hiding this comment.
so sorry i just realized this is plural, can you make it Get-DbaDbccUserOption and add an Option param for filtering. Then it should probably be Option, Value and we'll be set. If you don't see this by my time tomorrow, ill merge and update
There was a problem hiding this comment.
Should an Exclude option also be included?
There was a problem hiding this comment.
Nah, if i could go back in time, i'd only include Excludes in exports and copies
There was a problem hiding this comment.
Ok. I will make changes latter today and update the pull request
|
truly awesome! thanks so much 🙇 |
|
The new files are in the 0.9.535 release but the psd1 file is In the FunctionsToExport section |
|
my apologies. iwill fix this within the hour. |
|
fixed 👍 |
2 participants
Type of Change
Purpose
Implement the following DBCC Commands
DBCC HELP
DBCC FREEPROCCACHE
DBCC FREESESSIONCACHE
DBCC FREESYSTEMCACHE
DBCC MEMORYSTATUS
DBCC PROCCACHE
DBCC USEROPTIONS
Commands to test
Get-DbaDbccHelp
Get-DbaDbccMemoryStatus
Get-DbaDbccProcCache
Get-DbaDbccUserOptions
Invoke-DbaDbccFreeCache
Learning
Based on details in
https://docs.microsoft.com/en-us/sql/t-sql/database-console-commands/dbcc-transact-sql?view=sql-server-2017