Skip to content

Update-SqlPermission - Change test for updateability#8476

Merged
potatoqualitee merged 1 commit intodevelopmentfrom
UpdateSqlPermission_fix_check
Aug 15, 2022
Merged

Update-SqlPermission - Change test for updateability#8476
potatoqualitee merged 1 commit intodevelopmentfrom
UpdateSqlPermission_fix_check

Conversation

@andreasjordan
Copy link
Collaborator

Type of Change

  • Bug fix (non-breaking change, fixes Copy-DbaLogin cannot clone a login on AG primary #8442 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

I have not worked with the property IsUpdateable, but for AGs I can say that is it $true for the primaray and $false for the secondary.

So please review carefully.

@potatoqualitee
Copy link
Member

Nice! Thank you 🙇🏼

@potatoqualitee potatoqualitee merged commit f16ab2e into development Aug 15, 2022
@potatoqualitee potatoqualitee deleted the UpdateSqlPermission_fix_check branch August 15, 2022 08:50
@JohnnyHighhair
Copy link

I've have confirmed that issue https://github.com/dataplat/dbatools/issues/8442 ) has now been resolved. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy-DbaLogin cannot clone a login on AG primary

3 participants