Supporting custm -Port parameter when using PSRemoting (WinRM)#8494
Merged
potatoqualitee merged 8 commits intodevelopmentfrom Aug 19, 2022
Merged
Supporting custm -Port parameter when using PSRemoting (WinRM)#8494potatoqualitee merged 8 commits intodevelopmentfrom
potatoqualitee merged 8 commits intodevelopmentfrom
Conversation
Member
|
Solid changes, thank you so very much! Will approve once tests pass (There have been a couple legitimate failures so far) |
Member
|
just one more test to pass until merge! 😊 |
Member
|
gorrrge, thanks @ClaudioESSilva ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
.\tests\manual.pester.ps1)Purpose
Support a custom port when using PSRemoting
Approach
Made it configurable through
Set-DbatoolsConfig.Then it will be read when creating the parameter list to connect.
NOTE: Similar to the
-UseSSLconfiguration.Commands to test
Users need to set the wanted value for the port using
Set-DbatoolsConfigcommandCall any command that uses PSRemoting (WinRM)
To reset it (also on the notes) use: