Remove ConvertTo-SecureString from Examples#8540
Merged
potatoqualitee merged 2 commits intodevelopmentfrom Sep 17, 2022
Merged
Conversation
I've never been a fan of showing people how to do this -- they can figure it out if they need. I'd like to create a new policy that all Examples must be secure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will be enforcing a new policy that all Examples must be secure.
I've never been a fan of showing people how to use ConvertTo-SecureString because it's basically suggesting it's okay to type out a plain-text password at the console. If people need it for CI/CD, they can figure it out how to do it securely on other blog sites. Maybe I'll do a dbatools specific guide at some point.
Anyway, this Twitter thread is pure pain.