Route GitHub infrastructure changes through review - #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.collaboration.pullRequests.manageTemplateso repositories can require pull requests while keeping their existing template unmanagedhypervibe/github-infrastructurebranch and pull requestWhy
Hypervibe v0.1.3 unconditionally generated
.github/PULL_REQUEST_TEMPLATE.mdwheneverrequirePrwas enabled. Its environment deployment workflow apply path also wrote workflow files directly to the repository default branch and immediately synced secrets. Those behaviors prevented repositories from enforcing review for every infrastructure file change.User impact
Projects can set
manageTemplate: falseto preserve repository-owned pull-request templates. Applying deployment workflow drift now returns an honest pending receipt with the infrastructure PR URL; after a person merges it, a fresh plan/apply syncs the deferred secrets and bindings.Verification
npm run typechecknpm test -- --configLoader runner— 104 files and 813 tests passednpm run buildnpm_config_cache=/private/tmp/hypervibe-npm-cache npm run prepublish-checkgit diff --checkExisting expectations changed
The core deploy-workflow apply expectation now requires a pending infrastructure pull request rather than a successful direct repository write. New coverage proves secrets and bindings remain untouched before merge, are synchronized after the reviewed file appears on the default branch, and repository-owned templates are not deleted when ownership is released.
Risks / follow-up
manageTemplatedefaults totrue, preserving compatibility for existing desired-state specs.