Highlight indexed columns in completion menus#2058
Merged
Conversation
If a column is indexed, a configurable string is suffixed to it in the
completion menu (asterisk by default). The suffix is display-only, and
is not inserted when the completion is chosen.
Alternatively, a color or text style for indexed columns may be chosen
using
[colors]
completion-menu.completion.indexed = <style>
which is _not_ enabled by default.
For the purposes of the highlight, only the first column in a composite
index is treated as indexed.
Motivation: the user does not need to separately check EXPLAIN or
SHOW CREATE TABLE to know which columns will be best leveraged by a
WHERE or JOIN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a column is indexed, a configurable string is suffixed to it in the completion menu (asterisk by default). The suffix is display-only, and is not inserted when the completion is chosen.
Alternatively, a color or text style for indexed columns may be chosen using
which is not enabled by default.
For the purposes of the highlight, only the first column in a composite index is treated as indexed.
Motivation: the user does not need to separately check
EXPLAINorSHOW CREATE TABLEto know which columns will be best leveraged by aWHEREorJOIN.Example:
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).