Only ignore min completion trigger for /command term itself#2059
Merged
Conversation
rolandwalker
force-pushed
the
RW/completion-trigger-command-finesse
branch
from
July 25, 2026 18:45
6c9c2a4 to
ec90be5
Compare
Ignoring min_completion_trigger when the line starts with forward slash helps prompt for possible commands, but the previous implementation suppressed the setting throughout the entire line, applying also to the subcommands and further arguments of /command. Instead, the user's setting should be generally respected, and ignored _only_ for the first term, when /command is typed.
rolandwalker
force-pushed
the
RW/completion-trigger-command-finesse
branch
from
July 25, 2026 18:48
ec90be5 to
cd1298c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ignoring
min_completion_triggerwhen the line starts with forward slash helps prompt for possible commands, but the previous implementation suppressed the setting throughout the entire line, applying also to the subcommands and further arguments of/command.Instead, the user's setting should be generally respected, and ignored only for the first term, when
/commandis typed.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).