start_new_session when creating SSH tunnels - #2103
Merged
Merged
Conversation
According to * https://docs.python.org/3/library/subprocess.html#popen-constructor > If start_new_session is true the setsid() system call will be made in the child process prior to the execution of the subprocess. The hope is that setsid() keeps the tunnel process from receiving ctrl-c interrupts from the REPL.
Contributor
Author
|
Hm. This introduces a regression: the user cannot enter a password interactively if prompted by the SSH server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to
The hope is that
setsid()keeps the tunnel process from receiving ctrl-c interrupts from the REPL.Intended to address #2102.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).