There comments were orthogonal to the PR under review:
web/dds_web_wasm.cpp:42
Brace placement here is inconsistent with the surrounding Allman-style function definitions in this file, and with the repo C++ style guidelines for function definitions. Consider moving the opening brace onto its own line for readability and consistency.
web/dds_web_wasm.cpp:37
Brace placement here is inconsistent with the surrounding Allman-style function definitions in this file, and with the repo C++ style guidelines for function definitions. Consider moving the opening brace onto its own line for readability and consistency.
specs/web.md:28
This spec says the WASM module has "a single exported entry _dds_web_calc_table", but the BUILD linkopts export both calc_table and solve_leads. The invariant should match the actual exported surface so future emsdk/linkopt changes are reviewed correctly.
This issue also appears on line 36 of the same file.
specs/web.md:36
This bullet describes calling only dds_web_calc_table, but the page also calls dds_web_solve_leads for opening-lead analysis (see dds_web.js and the system smoke test). Updating the spec keeps it aligned with actual behavior.
There comments were orthogonal to the PR under review:
web/dds_web_wasm.cpp:42
Brace placement here is inconsistent with the surrounding Allman-style function definitions in this file, and with the repo C++ style guidelines for function definitions. Consider moving the opening brace onto its own line for readability and consistency.
web/dds_web_wasm.cpp:37
Brace placement here is inconsistent with the surrounding Allman-style function definitions in this file, and with the repo C++ style guidelines for function definitions. Consider moving the opening brace onto its own line for readability and consistency.
specs/web.md:28
This spec says the WASM module has "a single exported entry _dds_web_calc_table", but the BUILD linkopts export both calc_table and solve_leads. The invariant should match the actual exported surface so future emsdk/linkopt changes are reviewed correctly.
This issue also appears on line 36 of the same file.
specs/web.md:36
This bullet describes calling only dds_web_calc_table, but the page also calls dds_web_solve_leads for opening-lead analysis (see dds_web.js and the system smoke test). Updating the spec keeps it aligned with actual behavior.