Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .github/pull_request_templates/refactor_dynamic_environment.md

This file was deleted.

6 changes: 0 additions & 6 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,6 @@ config_setting(
define_values = {"ab_stats": "true"},
)

# Enable DDS_TT_CONTEXT_OWNERSHIP via --define=tt_context_ownership=true
config_setting(
name = "tt_context_ownership",
define_values = {"tt_context_ownership": "true"},
)

# Enable DDS_DEBUG_TT_RESET via --define=tt_reset_debug=true
config_setting(
name = "tt_reset_debug",
Expand Down
3 changes: 0 additions & 3 deletions CPPVARIABLES.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,6 @@ DDS_LOCAL_DEFINES = select({
}) + select({
"//:debug_all": ["DDS_DEBUG_ALL"],
"//conditions:default": [],
}) + select({
"//:tt_context_ownership": ["DDS_TT_CONTEXT_OWNERSHIP"],
"//conditions:default": [],
}) + select({
"//:tt_reset_debug": ["DDS_DEBUG_TT_RESET"],
"//conditions:default": [],
Expand Down
14 changes: 0 additions & 14 deletions library/tests/system/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,6 @@ cc_test(
],
)

# Same parity test, but with context TT ownership enabled to validate lazy TT path
cc_test(
name = "context_equivalence_test_ctx_tt",
size = "small",
srcs = ["context_equivalence_test.cpp"],
copts = [],
local_defines = ["DDS_TT_CONTEXT_OWNERSHIP"],
deps = [
"//library/src:testable_dds",
"//library/src/api:api_definitions",
"@googletest//:gtest_main",
],
)

# New lifecycle test that validates SolverContext-managed TT behavior
cc_test(
name = "context_tt_facade_test",
Expand Down
1 change: 0 additions & 1 deletion specs/build-system.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ than re-encoding toolchain knowledge.
| `debug_all` | `debug_all=true` | `DDS_DEBUG_ALL` | [constants-and-debug](constants-and-debug.md) |
| `ab_stats` | `ab_stats=true` | `DDS_AB_STATS` | [ab-stats](ab-stats.md) |
| `scheduler` | `scheduler=true` | `DDS_SCHEDULER` | [system-concurrency](system-concurrency.md) |
| `tt_context_ownership` | `tt_context_ownership=true` | `DDS_TT_CONTEXT_OWNERSHIP` | [transposition-table](transposition-table.md) (define wired but inert — no source `#ifdef`s it) |
| `tt_reset_debug` | `tt_reset_debug=true` | `DDS_DEBUG_TT_RESET` | [transposition-table](transposition-table.md) |
Comment thread
zzcgumn marked this conversation as resolved.
- **`DDS_LOCAL_DEFINES` is the standard `local_defines` for every core
`cc_library`; `DDS_SCHEDULER_DEFINE` is appended only where scheduler timing is
Expand Down
7 changes: 2 additions & 5 deletions specs/transposition-table.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,8 @@ its two concrete strategies, trading memory against speed.
that is not what `SearchContext::trans_table()` does.
- **Build-flag-gated diagnostics.** `tt_reset_debug` (`DDS_DEBUG_TT_RESET`) enables
reset-tracking diagnostics in `TransTableL` (wired through [build-system](build-system.md), off
by default). `tt_context_ownership` / `DDS_TT_CONTEXT_OWNERSHIP` remains a Bazel
`--define` in `CPPVARIABLES.bzl` but is **inert** today — no source `#ifdef`s
it. It is applied to one test target (`context_equivalence_test_ctx_tt` in
`library/tests/system/BUILD.bazel`), where it likewise has no effect;
ownership is always instance-scoped via `SearchContext`.
by default). TT ownership itself is not build-flag-gated — it is always
instance-scoped via `SearchContext`.
- **`testable_trans_table`** is the same sources exposed to
`//library/tests/trans_table/...` for white-box testing; behaviour is identical to
`trans_table`.
Expand Down