remove enable stake pool as an option, always enabled#398
Merged
dajohi merged 6 commits intodecred:masterfrom Jun 11, 2019
Merged
remove enable stake pool as an option, always enabled#398dajohi merged 6 commits intodecred:masterfrom
dajohi merged 6 commits intodecred:masterfrom
Conversation
chappjc
reviewed
May 28, 2019
Member
Author
|
rebased and will not err if option is set, option is just ignored, description tells of deprecation |
Member
|
@JoeGruffins please rebase |
remove setting from sample config file
Member
Author
|
rebased |
chappjc
requested changes
Jun 6, 2019
spelling
dajohi
requested changes
Jun 7, 2019
chappjc
approved these changes
Jun 10, 2019
jholdstock
approved these changes
Jun 11, 2019
dajohi
approved these changes
Jun 11, 2019
girino
added a commit
to girino/dcrstakepool
that referenced
this pull request
Sep 7, 2019
* commit 'b25f4307a2f1f956ab04c32919f7e88f66a4938d': multi: add ValidateAddress to stakepoold RPC (decred#406) show invalid ticket warning. (decred#395) multi: show last N voted tickets (decred#402) Get VoteVersion from stakepoold instead of dcrwallet (decred#403) remove enable stake pool as an option, always enabled (decred#398) prevent horizontal scrolling (decred#401) # Conflicts: # config.go
girino
added a commit
to girino/dcrstakepool
that referenced
this pull request
Sep 7, 2019
* commit 'f955590bef98437f79ee412969567f4d7ab117cf': remove enable stake pool as an option, always enabled (decred#398) # Conflicts: # config.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of issue #226
remove ability to disable stakepoold communications.
After making these changes, the user will need to remove the "enablestakepoold=" option from their config or see an error during parsing
This will cause merge conflicts with another of my pull requests...