Add ValidateAddress to stakepoold RPC#406
Merged
dajohi merged 1 commit intodecred:masterfrom Jun 11, 2019
Merged
Conversation
jholdstock
force-pushed
the
merged
branch
2 times, most recently
from
9a3b47b to
1aba75a
Compare
Member
Author
|
Rebased and ready for a review. |
chappjc
requested changes
Jun 11, 2019
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "github.com/decred/dcrd/dcrutil" |
Member
There was a problem hiding this comment.
imports need ordering (separate std lib from others)
|
|
||
| if v.IsMine != lastResponse.IsMine || | ||
| v.PubKeyAddr != lastResponse.PubKeyAddr { | ||
| vErr := fmt.Errorf("wallets %d and %d have different ValideAddress responses", |
Member
There was a problem hiding this comment.
would be good to log the mismatching fields (or just both fields from both responses)
|
|
||
| // Ensure responses are identical | ||
| var lastResponse *pb.ValidateAddressResponse | ||
| lastServer := 0 |
Member
There was a problem hiding this comment.
Just a style thing - at least in dcrdata's codebase, we always init with var name type when the zero value is desired. I'm not sure how consistent dcrstakepool is with variable initialization though.
dajohi
approved these changes
Jun 11, 2019
Merged
girino
added a commit
to girino/dcrstakepool
that referenced
this pull request
Sep 7, 2019
* commit 'b25f4307a2f1f956ab04c32919f7e88f66a4938d': multi: add ValidateAddress to stakepoold RPC (decred#406) show invalid ticket warning. (decred#395) multi: show last N voted tickets (decred#402) Get VoteVersion from stakepoold instead of dcrwallet (decred#403) remove enable stake pool as an option, always enabled (decred#398) prevent horizontal scrolling (decred#401) # Conflicts: # config.go
girino
added a commit
to girino/dcrstakepool
that referenced
this pull request
Sep 7, 2019
* commit 'b25f4307a2f1f956ab04c32919f7e88f66a4938d': multi: add ValidateAddress to stakepoold RPC (decred#406)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work is on top of #403, #402 and #395. Marking the PR as a draft, and I will rebase and request a review once the previous three are merged.
More work towards #227