Refactor : merging the refactor in lcao and pw#752
Closed
maki49 wants to merge 118 commits into
Closed
Conversation
range: source/module_base
delete useless code in tddft module
add #ifdef __MPI in codes related to MPI
Refactor: implement dm2d directly from `wfc_dm_2d.wfc_k` which can replace `set_EDM_k`
remove `WFC_GAMMA_aug` and `WFC_K_aug`; remove `new_dm` parameter; remove some uncalled inline functions
add changes for serial version
range: source/module_base
add #ifdef __MPI in codes related to MPI
Refactor : Tear down `GlobalC::ParaO` and `GlobalC::LNNR` ; remove `GlobalC::LM` and `GlobalC::UHM` by the way
test: add the unit test and comments for ylm.h
UT and annotations for math_bspline
add changes for serial version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(in this pr)
What I've done:
module_orbitalparallel_orbitals.h, .cppintomodule_orbitalORB_controlWhat I will do next
pzgemm_return diffrent result with the same input given #753src_pdiag/pdiag_common.h, .cpp,src_parallel/parallel_common.h, .cppintomodule_base? How to recover the independence ofmodule_orbitalafter moving in some parallel-code? #751