Refactor : merging the refactor in lcao and pw#762
Merged
Conversation
range: source/module_base
range: source/module_base/test/matrix_test.cpp
delete the redundant comment lines.
Test: add the unit test of module_orbital
test: add the unittest of module_base/matrix.h
Unittest for class realArray, IntArrray, Vector3 and mathzone
range: source/module_base/test
test:add the unittest and comments of math_ylmreal.h
test: UT and annotations in mathzone_add1
Fix deepmodeling#736: memory free by wrong index
range: source/module_base
move some functions into en_solver module Finally, we want to move all calculations about FP into en_solver/FP We only finish part of it. <All auto-tests passed>
test: add the unit test and comments for ylm.h
UT and annotations for math_bspline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pzgemm-bug #753 seems not easy to be resolved. So I closed #752 to protect test-passing of
pw_refactorbranch.What I've done in this pr:
module_orbitalparallel_orbitals.h, .cppintomodule_orbitalORB_controlWhat needs to be discussed:
src_pdiag/pdiag_common.h, .cpp,src_parallel/parallel_common.h, .cppintomodule_base? How to recover the independence ofmodule_orbitalafter moving in some parallel-code? #751