Skip to content

Conversation

@jamesbhobbs
Copy link
Contributor

@jamesbhobbs jamesbhobbs commented Oct 23, 2025

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration
    • Added automated spell-check validation to detect spelling errors in code files during build process

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

📝 Walkthrough

Walkthrough

Consolidates CI workflow configuration by removing the standalone .github/workflows/ci.yaml file and migrating its spell-check job into .github/workflows/ci.yml. The spell-check job retains its original configuration: runs on ubuntu-latest with a 10-minute timeout, checks out code, performs base setup, installs JupyterLab, and executes cspell across common file types.

Possibly related PRs

Suggested reviewers

  • Artmann
  • saltenasl
  • andyjakubowski

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "ci: fix ci dupe" refers directly to the main change in this PR—removing the duplicate .github/workflows/ci.yaml file and consolidating it with ci.yml. The term "dupe" is an informal abbreviation for "duplicate," and while somewhat abbreviated, it clearly conveys that the PR addresses a duplicate CI configuration issue. The message is specific enough that a teammate scanning history would understand the primary change.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2039e2 and 500434a.

📒 Files selected for processing (2)
  • .github/workflows/ci.yaml (0 hunks)
  • .github/workflows/ci.yml (1 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Lint & Format
  • GitHub Check: build
  • GitHub Check: check_release
🔇 Additional comments (3)
.github/workflows/ci.yml (3)

123-128: Job permissions override is appropriate.

The spell-check job correctly restricts permissions to only contents: read, following least-privilege principle. It doesn't need pull-request or package access.


123-140: Migration consolidated correctly.

The spell-check job is properly integrated with consistent step patterns (checkout → base-setup → install → run). File glob pattern is comprehensive for the intended scope.

The version `cspell@9.2.1` is the latest version, published 17 days ago and actively maintained. The pin is current and appropriate.

123-140: cspell version is current and valid.

The latest cspell npm version is 9.2.1, matching what's pinned in the workflow. The spell-check job structure is sound and follows established patterns.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.20%. Comparing base (b2039e2) to head (500434a).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   50.20%   50.20%           
=======================================
  Files          13       13           
  Lines         249      249           
  Branches       26       26           
=======================================
  Hits          125      125           
  Misses        119      119           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jamesbhobbs jamesbhobbs merged commit 74c383d into main Oct 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants