-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add cspell configuration and CI spell-check #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add cspell.json with Deepnote-specific file patterns - Configure spell-check to only check Deepnote code (not forked Microsoft code) - Add minimal 35-word technical dictionary - Add spell-check CI job to GitHub Actions workflow - Update package.json scripts to use cspell config Result: 49 files checked (Deepnote-specific only), 0 spelling errors
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
📝 WalkthroughWalkthroughAdds cspell-based spell-checking: introduces cspell.json config targeting specific source paths and ignore patterns; adds cspell dependency and a Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer (push)
participant GH as GitHub Actions
participant Runner as CI Runner
participant Node as Node/npm (cspell)
Dev->>GH: push PR
GH->>Runner: start CI
alt existing checks
Runner->>Runner: Checkout repo, Run "Check Licenses" job
Runner->>Node: npm ci\nnpm run spell-check (new step added)
Node-->>Runner: spell-check results
end
alt new standalone job
Runner->>Runner: Run "Spell Check" job
Runner->>Node: npm ci\nnpm run spell-check
Node-->>Runner: spell-check results
end
Runner->>GH: report status (pass/fail)
Possibly related PRs
Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=====================================
Coverage 71% 71%
=====================================
Files 523 523
Lines 39001 39001
Branches 4905 4905
=====================================
Hits 27834 27834
Misses 9542 9542
Partials 1625 1625 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
.github/workflows/ci.yml(1 hunks)cspell.json(1 hunks)package.json(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: jamesbhobbs
PR: deepnote/deepnote#1
File: package.json:24-28
Timestamp: 2025-09-30T13:33:12.669Z
Learning: In the deepnote repository, do not suggest adding spell-check to lint-staged pre-commit hooks due to performance concerns. Spell-check runs in CI instead.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build & Test
🔇 Additional comments (3)
cspell.json (3)
3-7: Scoping looks correct. File patterns target Deepnote-specific directories and avoid the forked Jupyter extension code. ✓
30-31: Validate "dont" and "DONT" — likely misspellings of "don't" / "DON'T".Both appear in the custom words list but look like typos rather than intentional terms. Verify they exist in your codebase before allowlisting them.
23-59: Verification passed—all spot-checked terms are legitimate code identifiers.The checked terms ("Reselecting", "DONT"/"dont") appear as actual identifiers and comments in the codebase, not misspelled words masked by the allowlist. Combined with the known technical terms (jupyter, ipykernel, numpy, venv), the custom words list is appropriate.
- Remove spell-check:fix script (didn't actually fix, just showed suggestions) - Add explicit --config cspell.json to spell-check script for clarity
Summary
Adds CSpell spell-checking configuration to vscode-deepnote repository, focusing only on Deepnote-specific code rather than the forked Microsoft vscode-jupyter codebase.
Changes Made
Spell-check configuration:
cspell.json: Configured to only check Deepnote-specific files:src/notebooks/deepnote/**src/kernels/deepnote/**src/platform/errors/deepnoteServerNotFoundError.tsCI integration:
.github/workflows/ci.yml: Added spell-check job that runsnpm run spell-checkPackage updates:
cspell@9.2.1as dev dependency"spell-check": "cspell --config cspell.json"@cspell/dict-en-common-misspellings@2.1.6to license checker exclusionsKey Design Decisions
Human Review Checklist
@cspell/dict-en-common-misspellings@2.1.6from license checks is acceptable for compliancecspell.jsonto ensure no actual misspellings were whitelisted instead of being fixedLink to Devin run: https://app.devin.ai/sessions/f834d045e38442e88bff0556346e3a2b
Requested by: @jamesbhobbs