Skip to content

Conversation

@jamesbhobbs
Copy link
Contributor

@jamesbhobbs jamesbhobbs commented Oct 10, 2025

Summary by CodeRabbit

  • Chores
    • Consolidated license validation into the primary CI pipeline, ensuring checks run with standard builds for pushes and pull requests.
    • Removed the standalone license-check workflow to reduce duplication and simplify maintenance.
    • Improved visibility by surfacing license results alongside existing CI jobs.
    • Internal-only change; no impact on application features or interfaces.
    • No action required from end-users.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 10, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Removes the standalone GitHub Actions workflow .github/workflows/check-licenses.yml that ran yarn check-licenses. Adds a new job license-check to .github/workflows/ci.yml with the same steps: checkout, base setup via jupyterlab/maintainer-tools action, and yarn check-licenses. The license check is now integrated into the main CI workflow instead of a separate workflow.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Developer
  participant GH as GitHub Actions
  participant CI as CI Workflow (.github/workflows/ci.yml)
  participant LC as Job: license-check
  participant Repo as Repository
  participant MT as maintainer-tools/base-setup
  participant Yarn as yarn

  Dev->>GH: Push / Pull Request
  GH->>CI: Trigger CI workflow
  CI->>LC: Start job (ubuntu-latest)

  rect rgba(227,242,253,0.6)
  note over LC: License Check (newly integrated into CI)
  LC->>Repo: actions/checkout@v4
  LC->>MT: Run base setup action
  LC->>Yarn: run "yarn check-licenses"
  Yarn-->>LC: Exit status (success/failure)
  end

  LC-->>CI: Job result
  CI-->>GH: Report CI status
Loading

Possibly related PRs

  • deepnote/deepnote-internal#18581: Adjusts CI to add/relocate a license-check job similar to this integration.
  • ci: add license checker #3: Introduces a standalone check-licenses workflow that this PR replaces by moving into CI.
  • ci: license checker vscode-deepnote#18: Adds a license-check job within .github/workflows/ci.yml, analogous to this change.

Suggested reviewers

  • andyjakubowski

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99eb48f and bf14ee5.

📒 Files selected for processing (2)
  • .github/workflows/check-licenses.yml (0 hunks)
  • .github/workflows/ci.yml (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@jamesbhobbs jamesbhobbs marked this pull request as ready for review October 10, 2025 10:18
@jamesbhobbs jamesbhobbs merged commit 7ac4a8e into main Oct 10, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants