-
Notifications
You must be signed in to change notification settings - Fork 4
ci: license checker #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds a CI "Check licenses" step to .github/workflows/ci.yml (runs Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions
participant Job as check_licenses
participant NPM as npm
participant LC as license-checker-rseidelsohn
Dev->>GH: Push / open PR
GH->>Job: trigger check_licenses job
Job->>Job: checkout, setup-node, npm ci
Job->>NPM: run "npm run check-licenses"
NPM->>LC: invoke with allowlist & exclusions
LC-->>NPM: produce report + exit code
alt exit code 0
Job-->>GH: job succeeds
GH-->>Dev: success status
else exit code != 0
Job-->>GH: job fails with report
GH-->>Dev: failure status
end
Possibly related PRs
Pre-merge checks❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (2)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
package.json (1)
2058-2058: Fix Windows quoting for--onlyAllow.Single quotes break the allowlist on Windows shells; we still need escaped double quotes so the CI is portable.
-"check-licenses": "npx license-checker-rseidelsohn --onlyAllow 'MIT;Apache-2.0;ISC;BSD-2-Clause;BSD-3-Clause;0BSD;Python-2.0;CC0-1.0;CC-BY-3.0;CC-BY-4.0;Unlicense;BlueOak-1.0.0;MPL-2.0' --excludePrivatePackages --excludePackages 'bootstrap-less@3.3.8'", +"check-licenses": "npx license-checker-rseidelsohn --onlyAllow \"MIT;Apache-2.0;ISC;BSD-2-Clause;BSD-3-Clause;0BSD;Python-2.0;CC0-1.0;CC-BY-3.0;CC-BY-4.0;Unlicense;BlueOak-1.0.0;MPL-2.0\" --excludePrivatePackages --excludePackages \"bootstrap-less@3.3.8\"",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci.yml(1 hunks)package.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI
.github/workflows/ci.yml
[warning] 1-1: Code style issues found in the file. Run Prettier to fix.
- Fix trailing whitespace in .github/workflows/ci.yml - Add BSD and 'Apache v2' to allowed licenses (alternate naming for BSD-2-Clause and Apache-2.0) - Exclude 4 devDependencies with WTFPL license: chai-as-promised, esbuild-plugin-less, truncate-utf8-bytes, utf8-byte-length - Exclude eslint-plugin-local-rules (local package with UNKNOWN license) All excluded packages are devDependencies used only for testing/building and are not bundled with the extension.
Fixes OSS-107
Summary by CodeRabbit