[wasm] Bump chrome for testing - linux: 127.0.6533.88, windows: 127.0.6533.89#55
Open
github-actions[bot] wants to merge 1 commit into
Open
[wasm] Bump chrome for testing - linux: 127.0.6533.88, windows: 127.0.6533.89#55github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
SamMonoRT
pushed a commit
that referenced
this pull request
Jun 15, 2026
…#129188) In Lowering::IsContainableUnaryOrBinaryOp, the maximum shift amount permitted for a contained shift (LSH/RSH/RSZ) was computed from the parent node's type. For comparison parents (GT_EQ/GT_NE/GT_LT/etc. and GT_TEST_EQ/GT_TEST_NE) the parent's type is TYP_INT regardless of operand width, so any shift amount in 32..63 fed into a 64-bit comparison would fail containment. As a result, we emitted lsl x1, x1, #55 cmp x0, x1 instead of the optimized cmp x0, x1, LSL #55 and similarly for ANDS-feeding patterns like (a & (b >> 38)) != 0. Use the shift node's own type to derive maxShift; for binary parents where parent and child types agree this is unchanged, and for compares it gives the correct operand width (31 for int, 63 for long). Update the existing FileCheck tests in Cmp.cs and And.cs that documented the old buggy codegen, and add CmpLargeShift64BitSwap to cover the swapped-operand long-compare path. Fixes dotnet#111889 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.