Native extension DLLs not copied to bundle output

[aglitchman]

Describe the bug (REQUIRED)
I added my dll files to the extensionname/lib/platform_name folder of a native extension, but when creating a bundle from the IDE or via Bob, these files are not copied to the output directory.

To Reproduce (REQUIRED)
demo.zip

Steps to reproduce the behavior:

1. Download the test project
2. Open the project
3. Do Project / Bundle / Windows Application... or run java -jar bob.jar --archive resolve clean build bundle --bundle-output OUTPUT --platform x86_64-win32

The result is:

Btw, the build/platformname/ folder contains files as it should, so the app runs well from IDE:

Expected behavior (REQUIRED)
The bundle should have all dlls from the extensionname/lib/platformname/ directory.

Defold version (REQUIRED):

• Version: 1.10.4

Platforms (REQUIRED):

• Platforms: Windows

[aglitchman]

I thought that maybe I missed some setting that enables copying dlls to the bundle?

[aglitchman]

Oh, should I duplicate the dlls in the extensionname/res/platformname folder as well?... I've just found that the Steam Extension bundles their dlls that way - https://github.com/defold/extension-steam/tree/master/steam/res/x86_64-win32

[britzl]

Oh, should I duplicate the dlls in the extensionname/res/platformname folder as well?... I've just found that the Steam Extension bundles their dlls that way - https://github.com/defold/extension-steam/tree/master/steam/res/x86_64-win32

We recently added support in the build server to return any dynamic libs from extensions to the build result (defold/extender#596), but it seems like this only takes us half way as we do not copy the dynamic libs to the bundle. In the Win32Bundler we have a comment about copying exe+dlls but we only copy the exe (and on MacOS we would need to copy to Contents/MacOS/):

https://github.com/defold/defold/blob/dev/com.dynamo.cr/com.dynamo.cr.bob/src/com/dynamo/bob/bundle/Win32Bundler.java#L104-L107

As for Project->Build in the editor we copy the contents from .internal/cache/<platform>/build.zip to build/<platform> which in this case is sufficient:

So the reason the Steam extension works is the fact that we have the libraries duplicated in steam/res/. I completely forgot about this and left old versions of the libs in that folder! 😱 (fixed now)