Fixes for 1.9.0-1.9.8#665
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b43c722437
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| After a package is mounted, an excluded and unloaded proxy can also be redirected to a different compiled collection with `collectionproxy.set_collection()`. See [Changing an excluded proxy's collection](/manuals/collection-proxy/#changing-an-excluded-proxys-collection) for the restrictions and loading sequence. | ||
|
|
||
| With *Strip Live Update Entries from Main Manifest* enabled, which is the default when publishing archive-based Live Update content: | ||
| The bundled main manifest omits excluded Live Update entries. `collectionproxy.get_resources()` reads manifest dependency metadata; it does not verify that every referenced data blob is available: |
There was a problem hiding this comment.
Restore the stripped-manifest caveat
When liveupdate.exclude_entries_from_main_manifest is disabled, the bundled game.dmanifest intentionally keeps the excluded entries, as described in docs/en/manuals/live-update.md, so this unconditional statement is false. In that configuration collectionproxy.get_resources() can return hashes before any package is mounted, which makes the example below skip download_archive and try to load a proxy whose data blobs are still unavailable. Please keep the “with Strip Live Update Entries from Main Manifest enabled/default” condition here.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
this option is already deprecated
No description provided.