Skip to content

Fixes for 1.9.0-1.9.8#665

Merged
AGulev merged 3 commits into
masterfrom
actualize-1.9.0-1.9.8
Jul 13, 2026
Merged

Fixes for 1.9.0-1.9.8#665
AGulev merged 3 commits into
masterfrom
actualize-1.9.0-1.9.8

Conversation

@AGulev

@AGulev AGulev commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@AGulev AGulev requested a review from britzl July 13, 2026 13:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b43c722437

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

After a package is mounted, an excluded and unloaded proxy can also be redirected to a different compiled collection with `collectionproxy.set_collection()`. See [Changing an excluded proxy's collection](/manuals/collection-proxy/#changing-an-excluded-proxys-collection) for the restrictions and loading sequence.

With *Strip Live Update Entries from Main Manifest* enabled, which is the default when publishing archive-based Live Update content:
The bundled main manifest omits excluded Live Update entries. `collectionproxy.get_resources()` reads manifest dependency metadata; it does not verify that every referenced data blob is available:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the stripped-manifest caveat

When liveupdate.exclude_entries_from_main_manifest is disabled, the bundled game.dmanifest intentionally keeps the excluded entries, as described in docs/en/manuals/live-update.md, so this unconditional statement is false. In that configuration collectionproxy.get_resources() can return hashes before any package is mounted, which makes the example below skip download_archive and try to load a proxy whose data blobs are still unavailable. Please keep the “with Strip Live Update Entries from Main Manifest enabled/default” condition here.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this option is already deprecated

@AGulev AGulev merged commit 46bab2c into master Jul 13, 2026
3 checks passed
@AGulev AGulev deleted the actualize-1.9.0-1.9.8 branch July 13, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants