fix(Makefile): change VERSION, add and fix targets#15
Merged
arschles merged 2 commits intodeis:masterfrom Dec 9, 2015
Merged
Conversation
- adding go test to test target - removing build target from docker-build - deleting the service on kube-clean
Member
There was a problem hiding this comment.
we recently removed this from etcd to get the deployments working again: deis/etcd#19
travis was failing because docker-machine was not found, even though we explicitly added DEIS_REGISTRY.
according to deis/etcd#19. also see deis#15 (comment) for further explanation
Member
Author
|
@bacongobbler removed |
arschles
added a commit
that referenced
this pull request
Dec 9, 2015
fix(Makefile): change VERSION, add and fix targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces part of #9