fix(Makefile): remove call to docker-machine#19
Merged
bacongobbler merged 1 commit intodeis:masterfrom Dec 8, 2015
Merged
Conversation
bacongobbler
force-pushed
the
remove-docker-machine-dep
branch
from
6db09e5 to
7c7dbe5
Compare
In other projects, we do not dictate how DEIS_REGISTRY or DEV_REGISTRY is set. This is handled by the developer. This fixes Travis and should allow deis/etcd to push images to quay once again.
bacongobbler
pushed a commit
that referenced
this pull request
Dec 8, 2015
fix(Makefile): remove call to docker-machine
Member
There was a problem hiding this comment.
for my reference, do people generally have preference for using export in makefiles for vars? I'm leveling up my makefile-fu...
arschles
added a commit
to arschles/deis-builder
that referenced
this pull request
Dec 9, 2015
according to deis/etcd#19. also see deis#15 (comment) for further explanation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In other projects, we do not dictate how DEIS_REGISTRY or DEV_REGISTRY
is set, other than DEIS_REGISTRY is the successor to DEV_REGISTRY. This is handled by the developer. This fixes Travis and should allow deis/etcd to push images to quay once again.
fixes #14