This repository was archived by the owner on May 6, 2020. It is now read-only.
feat(whitelist): Add support for IP whitelist#1010
Merged
kmala merged 1 commit intodeis:masterfrom Aug 26, 2016
Merged
Conversation
|
@helgi, @bacongobbler and @mboersma are potential reviewers of this pull request based on my analysis of |
Current coverage is 86.49% (diff: 95.83%)@@ master #1010 diff @@
==========================================
Files 28 28
Lines 3175 3244 +69
Methods 0 0
Messages 0 0
Branches 540 552 +12
==========================================
+ Hits 2735 2806 +71
+ Misses 292 289 -3
- Partials 148 149 +1
|
kmala
force-pushed
the
maint
branch
2 times, most recently
from
9c3966f to
b4c7544
Compare
Merged
3 tasks
| 'app_type': scale_type, | ||
| 'build_type': release.build.type, | ||
| 'healthcheck': healthcheck, | ||
| 'service_annotations': {'maintenance': app_settings.maintenance}, |
Contributor
Author
There was a problem hiding this comment.
its unused...thought i can cleanup a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #240