This repository was archived by the owner on Nov 30, 2021. It is now read-only.
feat(whitelist): Add docs for specifying application whitelist using deis client#477
Merged
kmala merged 1 commit intodeis:masterfrom Aug 26, 2016
Merged
feat(whitelist): Add docs for specifying application whitelist using deis client#477kmala merged 1 commit intodeis:masterfrom
kmala merged 1 commit intodeis:masterfrom
Conversation
| $ kubectl --namespace=example annotate service example-web router.deis.io/whitelist="10.0.1.0/24,121.212.121.212" | ||
| $ kubectl --namespace=example annotate service example-web router.deis.io/whitelist="10.0.1.0/24,121.212.121.212" | ||
|
|
||
| Application level whitelist can also be done using deis client. To add/remove/list addresses of an application whitelist, use `deis whitelist`: |
Contributor
There was a problem hiding this comment.
Application level whitelist can also be done using deis client.
Is a little awkward. Maybe "Application level whitelists can also be done using the deis client."
There also are not any example of listing application whitelists.
| $ kubectl --namespace=example annotate service example-web router.deis.io/whitelist="10.0.1.0/24,121.212.121.212" | ||
| $ kubectl --namespace=example annotate service example-web router.deis.io/whitelist="10.0.1.0/24,121.212.121.212" | ||
|
|
||
| Application level whitelisting can also be done using the deis client. To add/remove/list addresses of an application whitelist, use `deis whitelist`: |
Member
There was a problem hiding this comment.
Deis should be capitalized when used in a sentence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes deis/controller#240
This should be merged after corresponding code changes are merged.