Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

fix(scheduler): pass down the right variable for Deployment revision history limit#1037

Merged
helgi merged 1 commit intodeis:masterfrom
helgi:fix_revision_history
Sep 2, 2016
Merged

fix(scheduler): pass down the right variable for Deployment revision history limit#1037
helgi merged 1 commit intodeis:masterfrom
helgi:fix_revision_history

Conversation

@helgi
Copy link
Copy Markdown
Contributor

@helgi helgi commented Sep 2, 2016

Prior to this the wrong variable was being passed and as such the revision history feature did not work

@helgi helgi added this to the v2.5 milestone Sep 2, 2016
@helgi helgi self-assigned this Sep 2, 2016
@deis-bot
Copy link
Copy Markdown

deis-bot commented Sep 2, 2016

@kmala, @bacongobbler and @mboersma are potential reviewers of this pull request based on my analysis of git blame information. Thanks @helgi!

…history limit

Prior to this the wrong variable was being passed and as such the revision history feature did not work
@helgi helgi force-pushed the fix_revision_history branch from cc1ea01 to 2e37e99 Compare September 2, 2016 18:45
@helgi helgi added the k8s label Sep 2, 2016
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 2, 2016

Current coverage is 87.07% (diff: 0.00%)

Merging #1037 into master will increase coverage by 0.02%

@@             master      #1037   diff @@
==========================================
  Files            42         42          
  Lines          3567       3567          
  Methods           0          0          
  Messages          0          0          
  Branches        602        602          
==========================================
+ Hits           3105       3106     +1   
+ Misses          302        301     -1   
  Partials        160        160          

Powered by Codecov. Last update 83df91e...2e37e99

@kmala kmala added the LGTM1 label Sep 2, 2016
@helgi helgi merged commit 3f3a228 into deis:master Sep 2, 2016
@helgi helgi deleted the fix_revision_history branch September 2, 2016 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants