Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

fix(scheduler): pass down the right variable for Deployment revision history limit #1037

Merged
helgi merged 1 commit into from
Sep 2, 2016
Merged

fix(scheduler): pass down the right variable for Deployment revision history limit #1037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rootfs/api/models/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ def deploy(self, release, force_deploy=False):
'routable': routable,
'deploy_batches': batches,
'deploy_timeout': deploy_timeout,
'deployment_history_limit': deployment_history,
'deployment_revision_history_limit': deployment_history,
'release_summary': release.summary,
'pod_termination_grace_period_seconds': pod_termination_grace_period_seconds,
'image_pull_secret_name': image_pull_secret_name,
Expand Down
4 changes: 2 additions & 2 deletions rootfs/scheduler/resources/deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ def manifest(self, namespace, name, image, entrypoint, command, **kwargs):
}

# Add in how many deployment revisions to keep
if kwargs.get('deployment_revision_history', None) is not None:
manifest['spec']['revisionHistoryLimit'] = int(kwargs.get('deployment_revision_history')) # noqa
if kwargs.get('deployment_revision_history_limit', None) is not None:
manifest['spec']['revisionHistoryLimit'] = int(kwargs.get('deployment_revision_history_limit')) # noqa

# tell pod how to execute the process
kwargs['command'] = entrypoint
Expand Down