Merged
Conversation
Member
There was a problem hiding this comment.
was there something wrong with the current implementation that requires the call to isset() here?
Contributor
Author
There was a problem hiding this comment.
@bacongobbler it would throw a notice (unseen due to error display settings, but still happens) if the key didn't exist. This is just the correct way to do this.
Member
|
LGTM |
Member
|
LGTM. |
Member
|
Tested against Deis master: $ deis create
Creating application... done, created deluxe-handbill
Git remote deis added
$ git push deis dshafik-add-container-id
Counting objects: 222, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (153/153), done.
Writing objects: 100% (222/222), 367.82 KiB | 0 bytes/s, done.
Total 222 (delta 61), reused 216 (delta 59)
-----> PHP app detected
-----> Resolved composer.lock requirement for PHP to version 5.6.7.
-----> Installing system packages...
- PHP 5.6.7
- Apache 2.4.10
- Nginx 1.6.0
-----> Installing PHP extensions...
- zend-opcache (automatic; bundled)
...
Step 5 : ENV GIT_SHA ab279133cac4e010ba1393a07e33f51084ef12cb
---> Running in 5624d0908a66
---> f05896b3998e
Removing intermediate container 5624d0908a66
Successfully built f05896b3998e
-----> Pushing image to private registry
-----> Launching...
done, deluxe-handbill:v2 deployed to Deis
http://deluxe-handbill.local3.deisapp.com
To learn more, use `deis help` or visit http://deis.io
To ssh://git@deis.local3.deisapp.com:2222/deluxe-handbill.git
* [new branch] dshafik-add-container-id -> dshafik-add-container-id
$ curl http://deluxe-handbill.local3.deisapp.com
Powered by Deis!
Running on container ID 486f77e8a7cb
$ deis scale web=3
Scaling processes... but first, coffee!
done in 124s
=== deluxe-handbill Processes
--- web:
web.1 up (v2)
web.2 up (v2)
web.3 up (v2)
$ curl http://deluxe-handbill.local3.deisapp.com
Powered by Deis!
Running on container ID 486f77e8a7cb
$ curl http://deluxe-handbill.local3.deisapp.com
Powered by Deis!
Running on container ID f4b18d36756a
$ curl http://deluxe-handbill.local3.deisapp.com
Powered by Deis!
Running on container ID eb49c678bfd7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.