Skip to content

Show container ID in output #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mboersma merged 1 commit into from
May 30, 2015
Merged

Show container ID in output #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion web/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

$app = new \Slim\Slim();
$app->get('/', function () {
echo "Powered by " . ($_ENV["POWERED_BY"] ? $_ENV["POWERED_BY"] : "Deis") . "\n";
$container = trim(exec('hostname') ?: "unknown");
echo "Powered by " . (isset($_ENV["POWERED_BY"]) ? $_ENV['POWERED_BY'] : "Deis!") . "\n";
Copy link
Member

@bacongobbler bacongobbler May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was there something wrong with the current implementation that requires the call to isset() here?

Copy link
Contributor Author

@dshafik dshafik May 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bacongobbler it would throw a notice (unseen due to error display settings, but still happens) if the key didn't exist. This is just the correct way to do this.

echo "Running on container ID " . $container . "\n";
});
$app->run();

Expand Down